Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (27 files)
Reviewed by gpt-5.5-20260423 · 2,118,844 tokens |
Wrap the bot.webhooks.github call in after() with try/catch so unhandled exceptions from the chat adapter are surfaced to Sentry instead of being silently dropped.
Replace the manual last-page / previous-page pagination dance with a single octokit call using sort=created&direction=desc. GitHub already supports returning the newest comments first, so one request suffices.
The review-thread context helper previously paged through every review comment on the pull request with no upper bound. For PRs with thousands of review comments this produced a long cascade of API calls on every bot mention. Cap at 500 comments (5 pages of 100) and log when the cap is reached so we can spot pathological PRs.
Both /github/link and the bot-link branch of the GitHub App callback were hard-coded to 'standard' credentials, so account linking would fail for installations of the lite app. Look up the integration by installation_id and pick credentials / exchange the OAuth code using its stored github_app_type.
Replace the global `identity:github:user:<githubUserId>` link with the same per-installation identity Slack uses. GitHub link URLs now carry an HMAC-signed token binding them to a specific platform integration, so they remain safe to post in public issue/PR comments.
markijbema
approved these changes
May 6, 2026
Contributor
markijbema
left a comment
There was a problem hiding this comment.
- This GitHub adapter has so many webhook feelings it should come with a therapist and a retry queue.
- The account linking flow says "seamless" the way a merge conflict says "almost done."
- Prompt context is stuffed so full even Copilot would ask for a smaller diff.
- The mocks are bravely pretending concurrency is a myth invented by flaky CI.
- Overall, PR #3024 adds GitHub support with the confidence of a bot that just learned
awaitmeans "eventually."
Contributor
Author
|
@kilocode-bot hi, how are you? |
Contributor
|
Hi! I'm doing great, thanks for asking! 😊 I'm Kilo Bot, ready to help you with code analysis, making changes, fixing bugs, implementing features, and more on your repositories. Is there anything I can help you with on this PR or elsewhere? For more on what I can do, check out the docs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
N/A (no manual verification performed).
Visual Changes
N/A
Reviewer Notes
pull_requestwebhook path.