chore(gastown): drop unused promise param from unhandledRejection handler#3074
Merged
jrf0110 merged 1 commit intogastown-stagingfrom May 6, 2026
Merged
chore(gastown): drop unused promise param from unhandledRejection handler#3074jrf0110 merged 1 commit intogastown-stagingfrom
jrf0110 merged 1 commit intogastown-stagingfrom
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by gpt-5.5-20260423 · 89,579 tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3072. Toast removed
String(promise)(the no-base-to-string lint error) but left thepromiseparameter declared, tripping a different lint rule:Drops the parameter entirely. Also removes the now-redundant
event: 'unhandled_rejection'field from the log payload — the log key (container.unhandled_rejection) already conveys that.Unblocks PR #2974 (
gastown-staging→mainpromote).