Skip to content

chore(gastown): drop unused promise param from unhandledRejection handler#3074

Merged
jrf0110 merged 1 commit intogastown-stagingfrom
fix/staging-ci-unused-param
May 6, 2026
Merged

chore(gastown): drop unused promise param from unhandledRejection handler#3074
jrf0110 merged 1 commit intogastown-stagingfrom
fix/staging-ci-unused-param

Conversation

@jrf0110
Copy link
Copy Markdown
Contributor

@jrf0110 jrf0110 commented May 6, 2026

Follow-up to #3072. Toast removed String(promise) (the no-base-to-string lint error) but left the promise parameter declared, tripping a different lint rule:

Parameter 'promise' is declared but never used. Unused parameters should start with a '_'.

Drops the parameter entirely. Also removes the now-redundant event: 'unhandled_rejection' field from the log payload — the log key (container.unhandled_rejection) already conveys that.

Unblocks PR #2974 (gastown-stagingmain promote).

@jrf0110 jrf0110 merged commit e20d04f into gastown-staging May 6, 2026
2 checks passed
@jrf0110 jrf0110 deleted the fix/staging-ci-unused-param branch May 6, 2026 15:56
@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 6, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (1 files)
  • services/gastown/container/src/main.ts

Reviewed by gpt-5.5-20260423 · 89,579 tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant