Conversation
RSO
approved these changes
Feb 4, 2026
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/functions/limitations |
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| // Sync selectedModel when a different project loads (projectModel changes from initial) | ||
| useEffect(() => { | ||
| if (projectModel) { | ||
| if (projectModel && projectModel !== initialProjectModelRef.current) { |
Contributor
There was a problem hiding this comment.
WARNING: Model sync only triggers when the model ID string changes
If you navigate to a different project that happens to use the same projectModel value as the previous project, this effect will not run, so selectedModel can incorrectly carry over a prior user selection. Consider keying this sync off a project identity (e.g., project id / manager) rather than projectModel value, or resetting selectedModel when the manager/project changes.
Contributor
Code Review SummaryStatus: 1 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments: None. Files Reviewed (4 files)
|
eshurakov
deleted the
eshurakov/app-builder-fix-model-selection-on-reload
branch
5 tasks
jeanduplessis
added a commit
that referenced
this pull request
Mar 28, 2026
Turborepo was evaluated and deferred. The root build/test/lint scripts have specific semantics that turbo run would silently broaden (e.g., fanning out to EAS builds, Bun wrappers). CI has intentionally separate jobs for cloud-agent, cloud-agent-next, and matrix workspace tests that would lose failure isolation under turbo run test. The existing shell scripts already handle orchestration including trpc prebuilds. Changes: - Remove Phase 9 (Add Turborepo) and renumber subsequent phases - Replace turbo run references in Phase 8 root scripts with explicit pnpm --filter and scripts/ delegates - Remove turbo.json from target structure - Remove turbo from root devDependencies - Update concern #4 to document the rationale for deferral - Add Turborepo to Out of Scope section for future evaluation
Open
42 tasks
jrf0110
added a commit
that referenced
this pull request
Apr 3, 2026
…review fixes - Fix #1: Add WHERE clause to updateConfig (config.ts accepts wastelandId param) - Fix #2: Update router.ts and ownership.ts imports from stub to Wasteland.do - Fix #3: initializeWasteland/storeCredential/updateConfig now return records - Fix #4: Implement all 6 missing RPC methods (updateMember, connectTown, disconnectTown, listConnectedTowns, getWantedBoard, refreshWantedBoard) - Fix #5: Synchronous initializeDatabase(), no ensureInitialized/initPromise - Fix #7: Delete WastelandDO.stub.ts New files: - 5 table definitions under db/tables/ (config, members, credentials, connected-towns, wanted-cache) - 5 sub-modules under dos/wasteland/ with business logic - Wasteland.do.ts: thin DO class delegating to sub-modules
jeanduplessis
added a commit
that referenced
this pull request
Apr 5, 2026
Turborepo was evaluated and deferred. The root build/test/lint scripts have specific semantics that turbo run would silently broaden (e.g., fanning out to EAS builds, Bun wrappers). CI has intentionally separate jobs for cloud-agent, cloud-agent-next, and matrix workspace tests that would lose failure isolation under turbo run test. The existing shell scripts already handle orchestration including trpc prebuilds. Changes: - Remove Phase 9 (Add Turborepo) and renumber subsequent phases - Replace turbo run references in Phase 8 root scripts with explicit pnpm --filter and scripts/ delegates - Remove turbo.json from target structure - Remove turbo from root devDependencies - Update concern #4 to document the rationale for deferral - Add Turborepo to Out of Scope section for future evaluation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
selectedModelwhile waiting for the models API to load, then failed to restore it becauseprojectModelwas always truthy (defaults toanthropic/claude-sonnet-4)Changes
initialProjectModelRef) to track the initial project model and only sync when a different project loads