Expose all free OpenRouter models#92
Conversation
- Remove function definition from src/lib/providers/openrouter/index.ts - Remove filter condition using isRateLimitedToDeathFree in enhancedModelList - Remove import and filter condition in sync-providers.ts - Remove import and check in openrouter route.ts :free models are now always allowed since: - isFreeModel returns true for :free models - isDataCollectionRequiredOnKiloCodeOnly returns false for :free models
Code Review SummaryStatus: 10 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
SUGGESTION
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments: None. Files Reviewed (11 files)
|
|
My reasoning for this change is:
|
markijbema
left a comment
There was a problem hiding this comment.
🤷
does feel like we then want to filter out ones later because we get tons of complains of them not working
| return modelDoesNotExistResponse(); | ||
| } | ||
|
|
||
| if (isRateLimitedToDeathFree(originalModelIdLowerCased)) { |
There was a problem hiding this comment.
What did this used to be for?
There was a problem hiding this comment.
to prevent people from manually modifying model ids to end in :free
| export const preferredModels = recommendedModels.map(m => m.public_id); | ||
|
|
||
| const freeOpenRouterModels = [ | ||
| 'openrouter/aurora-alpha', |
There was a problem hiding this comment.
This does look a lot cleaner and easier to manage. I imagine the need for this is models that don't end in :free but are indeed free?
There was a problem hiding this comment.
yeah, otherwise they would require a positive balance to be used (but would still be free)
Summary
Remove the
isRateLimitedToDeathFreefunction from the codebase since:freemodels are now always allowed.Changes
src/lib/providers/openrouter/index.tsisRateLimitedToDeathFreeinenhancedModelListsync-providers.tsroute.tsContext
:freemodels are now always allowed because:isFreeModelreturns true for:freemodelsisDataCollectionRequiredOnKiloCodeOnlyreturns false for:freemodelsBuilt for Christiaan by Kilo for Slack