Skip to content

fix(settings): clear default_model when provider_deny_list blocks it #930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrarnoldus merged 1 commit into from
Mar 9, 2026
Merged

fix(settings): clear default_model when provider_deny_list blocks it #930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions src/routers/organizations/organization-settings-router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,20 +220,23 @@ export const organizationsSettingsRouter = createTRPCRouter({
settingsUpdate.provider_deny_list = [...new Set(provider_deny_list)]; // Deduplicate slugs
}

// Check if default_model needs to be cleared
// Check if default_model needs to be cleared when deny lists change
if (
settingsUpdate.model_deny_list !== undefined &&
currentSettings.default_model &&
settingsUpdate.model_deny_list.length > 0
(model_deny_list !== undefined || provider_deny_list !== undefined) &&
currentSettings.default_model
) {
const isAllowed = createAllowPredicateFromDenyList(
settingsUpdate.model_deny_list,
settingsUpdate.provider_deny_list
);

if (!(await isAllowed(currentSettings.default_model))) {
// Clear default_model if it's no longer allowed
settingsUpdate.default_model = undefined;
const effectiveModelDenyList = settingsUpdate.model_deny_list ?? [];
const effectiveProviderDenyList = settingsUpdate.provider_deny_list ?? [];
if (effectiveModelDenyList.length > 0 || effectiveProviderDenyList.length > 0) {
const isAllowed = createAllowPredicateFromDenyList(
effectiveModelDenyList,
effectiveProviderDenyList
);

if (!(await isAllowed(currentSettings.default_model))) {
// Clear default_model if it's no longer allowed
settingsUpdate.default_model = undefined;
}
}
}

Expand Down