docs: review of PR #321 (refactor by bernaferrari)#324
Draft
markijbema wants to merge 2 commits intodevfrom
Draft
docs: review of PR #321 (refactor by bernaferrari)#324markijbema wants to merge 2 commits intodevfrom
markijbema wants to merge 2 commits intodevfrom
Conversation
markijbema
changed the title
markijbema
force-pushed
the
mark/pr-321-review
branch
from
ea4bb3b to
3ea9f7a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security-focused code review of PR #321 (bernaferrari's refactor).
Findings organized by severity:
Verdict: Merge with conditions.
See
pr-321-review-final.mdfor the executive summary andpr-321-review.mdfor the full detailed review.