fix(vscode): add extension icon for marketplace#389
Open
doozie-akshay wants to merge 2 commits intoKilo-Org:devfrom
Open
fix(vscode): add extension icon for marketplace#389doozie-akshay wants to merge 2 commits intoKilo-Org:devfrom
doozie-akshay wants to merge 2 commits intoKilo-Org:devfrom
Conversation
The extension was missing the top-level 'icon' field in package.json which VS Code uses for the extension icon in the marketplace and sidebar. Fixes Kilo-Org#346
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The extension was missing the top-level
iconfield inpackage.jsonwhich VS Code uses for the extension icon in the marketplace and sidebar.Problem
Solution
Added
"icon": "assets/icons/kilo-light.png"topackage.jsonTesting
assets/icons/kilo-light.png(256x256 PNG)Fixes #346