feat: add X-KiloCode-MachineId header to API requests#417
Open
chrarnoldus wants to merge 2 commits intodevfrom
Open
feat: add X-KiloCode-MachineId header to API requests#417chrarnoldus wants to merge 2 commits intodevfrom
chrarnoldus wants to merge 2 commits intodevfrom
Conversation
![kiloconnect[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| @@ -237,10 +239,9 @@ export namespace LLM { | |||
| ...(input.model.api.npm === "@kilocode/kilo-gateway" && input.agent.name | |||
Contributor
There was a problem hiding this comment.
SUGGESTION: Missed isKilo refactor — this line still uses the inline input.model.api.npm === "@kilocode/kilo-gateway" check instead of the newly extracted isKilo variable used on lines 243-244.
Suggested change
| ...(input.model.api.npm === "@kilocode/kilo-gateway" && input.agent.name | |
| ...(isKilo && input.agent.name |
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)SUGGESTION
Files Reviewed (5 files)
|
… is not set
When dataPath is empty (not configured), path.join('', 'telemetry-id')
resolves to a relative path, causing the telemetry-id file to be written
to the user's current working directory. This results in random
telemetry-id files appearing in project directories.
Return undefined instead of persisting when no data path is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #415
Fix: Prevent telemetry-id file from being written to working directory
When
dataPathis not configured (empty string),path.join("", "telemetry-id")resolves to"telemetry-id"— a relative path that causes the file to be written to the user's current working directory. This results in randomtelemetry-idfiles appearing in project directories.Change: In
Identity.getMachineId(), returnundefinedwhendataPathis not set instead of falling through to write a file in the CWD. All callers already handleundefinedgracefully.Built for Christiaan by Kilo for Slack