Skip to content

Conversation

@guymaness2
Copy link
Contributor

@guymaness2 guymaness2 commented Mar 22, 2024

Thank you for your code contribution, we will take your code suggestion into consideration. It will be reviewed, and based on code quality and need addressed, we will determine acceptance. If this code addresses a feature request or issue, be sure to link to that issue.

Description

What does the change add or fix?
  • Various bug fixes to allow multiple bulldozer passes on same data base without dictionary conflicts.
  • Various changes and fixes to be able to support using PCO Slingshot generated csv files for import.

Release Notes

What does the change add or fix in a succinct statement that will be read by clients?
  • Various bug fixes to allow multiple bulldozer passes on same data base without dictionary conflicts.
  • Various changes and fixes to be able to support using PCO Slingshot generated csv files for import.

Requested By

Who reported, requested, or paid for the change?

Warranty


Screenshots

Does this update or add options to the block UI?

no


Change Log

What files does it affect?
  • Bulldozer.CSV/Bulldozer.CSV.csproj
  • Bulldozer.CSV/CSVComponent.cs
  • Bulldozer.CSV/CSVInstance.cs
  • Bulldozer.CSV/Maps/Attendance.cs
  • Bulldozer.CSV/Maps/Financial.cs
  • Bulldozer.CSV/Maps/FinancialTransaction.cs
  • Bulldozer.CSV/Maps/Group.cs
  • Bulldozer.CSV/Maps/Location.cs
  • Bulldozer.CSV/Maps/Notes.cs
  • Bulldozer.CSV/Maps/Person.cs
  • Bulldozer.CSV/Maps/Prayer.cs
  • Bulldozer.CSV/Maps/Schedule.cs
  • Bulldozer.CSV/Model/EntityNoteCsv.cs
  • Bulldozer.CSV/Model/FinancialAccountCsv.cs
  • Bulldozer.CSV/Model/FinancialBatchCsv.cs
  • Bulldozer.CSV/Model/LocationCsv.cs
  • Bulldozer.CSV/Model/PersonNoteCsv.cs
  • Bulldozer.CSV/Model/ScheduleCsv.cs
  • Bulldozer/Bulldozer.csproj
  • Bulldozer/Model/AttendanceImport.cs
  • Bulldozer/Model/NoteImport.cs
  • Bulldozer/Utility/AddMethods.cs
  • Bulldozer/Utility/Extensions.cs

Migrations/External Impacts

Is it a breaking change for other versions/clients?

no

@guymaness2 guymaness2 requested a review from nateh777 March 22, 2024 22:27
@guymaness2
Copy link
Contributor Author

Ended on 67bacca

guymaness2 and others added 2 commits April 2, 2024 16:44
Co-authored-by: Nate H <nateh777@users.noreply.github.com>
@guymaness2
Copy link
Contributor Author

@nateh777 resolved all issues from code review. Reworked and tested Notes import section. Ready for review.

Co-authored-by: Nate H <nateh777@users.noreply.github.com>
@guymaness2
Copy link
Contributor Author

@nateh777 pulled changes in and rebuilt. Was there something you needed me to test, or are we good for merge?

@nateh777
Copy link
Member

@guymaness2 I believe just attributeDefinedTypeDict changes being checked to ensure we really are using the proper keys everywhere, otherwise I think it was good to go. I'll approve.

@nateh777 nateh777 merged commit cb17fc5 into master Apr 25, 2024
@nateh777 nateh777 deleted the bug/MinorBugFixes branch April 25, 2024 19:18
nateh777 added a commit that referenced this pull request Apr 25, 2024
Bug fixes from migration run using Slingshot files

(cherry picked from commit cb17fc5)
nateh777 added a commit that referenced this pull request Apr 25, 2024
Bug fixes from migration run using Slingshot files

(cherry picked from commit cb17fc5 with 1 merge conflict addressed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants