-
Notifications
You must be signed in to change notification settings - Fork 9
Bug fixes from migration run using Slingshot files #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… quite a bit in PCO data)
|
Ended on 67bacca |
Co-authored-by: Nate H <nateh777@users.noreply.github.com>
|
@nateh777 resolved all issues from code review. Reworked and tested Notes import section. Ready for review. |
Co-authored-by: Nate H <nateh777@users.noreply.github.com>
|
@nateh777 pulled changes in and rebuilt. Was there something you needed me to test, or are we good for merge? |
|
@guymaness2 I believe just attributeDefinedTypeDict changes being checked to ensure we really are using the proper keys everywhere, otherwise I think it was good to go. I'll approve. |
Bug fixes from migration run using Slingshot files (cherry picked from commit cb17fc5)
Bug fixes from migration run using Slingshot files (cherry picked from commit cb17fc5 with 1 merge conflict addressed)
Thank you for your code contribution, we will take your code suggestion into consideration. It will be reviewed, and based on code quality and need addressed, we will determine acceptance. If this code addresses a feature request or issue, be sure to link to that issue.
Description
What does the change add or fix?
Release Notes
What does the change add or fix in a succinct statement that will be read by clients?
Requested By
Who reported, requested, or paid for the change?
Warranty
Screenshots
Does this update or add options to the block UI?
no
Change Log
What files does it affect?
Migrations/External Impacts
Is it a breaking change for other versions/clients?
no