Skip to content

Conversation

@guymaness2
Copy link
Contributor

@guymaness2 guymaness2 commented May 10, 2024

Description

What does the change add or fix?
  • Fixed bug causing some Defined Value type attribute value imports to fail.
  • Fixed bug causing errors with importing group members
  • Fixed bug causing errors with financial account imports with empty campus fields
  • Added support for Group Attributes and Group Roles from inherited group types

Release Notes

What does the change add or fix in a succinct statement that will be read by clients?
  • Fixed bug causing some Defined Value type attribute value imports to fail.
  • Fixed bug causing errors with importing group members
  • Fixed bug causing errors with financial account imports with empty campus fields
  • Added support for Group Attributes and Group Roles from inherited group types

Requested By

Who reported, requested, or paid for the change?

Warranty


Screenshots

Does this update or add options to the block UI?

no


Change Log

What files does it affect?
  • Bulldozer.CSV/HelperMethods.cs
  • Bulldozer.CSV/Maps/Financial.cs
  • Bulldozer.CSV/Maps/Group.cs
  • Bulldozer.CSV/SampleCSVs/account.csv
  • Bulldozer.CSV/SampleCSVs/financial-account.csv

Migrations/External Impacts

Is it a breaking change for other versions/clients?

no

@guymaness2 guymaness2 marked this pull request as ready for review May 10, 2024 20:21
@guymaness2 guymaness2 requested a review from nateh777 May 10, 2024 20:26
@guymaness2
Copy link
Contributor Author

@nateh777 these changes have been tested with sample csv files and work without exceptions, save 2 intentional exceptions to show how empty group member roles will be set to default role for group type.

Copy link
Member

@nateh777 nateh777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one question, #102 (comment), if that is okay then it is good to go. Just let me know.

@nateh777 nateh777 merged commit b10d7fa into master May 17, 2024
@nateh777 nateh777 deleted the bug/bugFixes branch May 17, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants