Skip to content

Conversation

@KKould
Copy link
Member

@KKould KKould commented Mar 25, 2024

What problem does this PR solve?

  • perf Tuple::serialize_to: avoid DataValue::to_raw frequently creating Vec
  • add Function: current_date
select current_date;

+----------------+
| current_date() |
+================+
| 2024-03-25     |
+----------------+
  • add Type: LogicalType::Time
CREATE TABLE test (id int primary key, c1 time);
INSERT INTO test VALUES (0, '01:02:03'), (1, '02:03:03');

select * from test;

+---------+----------+
| test.id | test.c1  |
+====================+
| 0       | 01:02:03 |
|---------+----------|
| 1       | 02:03:03 |
+---------+----------+

Issue link: #130

What is changed and how it works?

Code changes

  • Has Rust code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Note for reviewer

@KKould KKould self-assigned this Mar 25, 2024
@KKould KKould added the enhancement New feature or request label Mar 25, 2024
@KKould KKould requested a review from crwen March 25, 2024 14:19
@KKould KKould changed the title Feat/type time Feat: add Function: current_date & add Type: LogicalType::Time Mar 25, 2024
@KKould KKould mentioned this pull request Mar 25, 2024
48 tasks
@KKould KKould merged commit faf27fe into KipData:main Mar 25, 2024
@KKould KKould added this to the SQL 2016 milestone Jul 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants