-
-
Notifications
You must be signed in to change notification settings - Fork 228
Update to version 8 #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to version 8 #256
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -328,6 +328,29 @@ private void Write(BuildMessageEventArgs e) | |
| Write((TargetSkippedEventArgs)e); | ||
| return; | ||
| } | ||
| if (e is PropertyReassignmentEventArgs) | ||
| { | ||
| Write((PropertyReassignmentEventArgs)e); | ||
| return; | ||
| } | ||
|
|
||
| if (e is UninitializedPropertyReadEventArgs) | ||
| { | ||
| Write((UninitializedPropertyReadEventArgs)e); | ||
| return; | ||
| } | ||
|
|
||
| if (e is EnvironmentVariableReadEventArgs) | ||
| { | ||
| Write((EnvironmentVariableReadEventArgs)e); | ||
| return; | ||
| } | ||
|
|
||
| if (e is PropertyInitialValueSetEventArgs) | ||
| { | ||
| Write((PropertyInitialValueSetEventArgs)e); | ||
| return; | ||
| } | ||
|
|
||
| Write(BinaryLogRecordKind.Message); | ||
| WriteMessageFields(e); | ||
|
|
@@ -352,6 +375,38 @@ private void Write(TargetSkippedEventArgs e) | |
| Write((int)e.BuildReason); | ||
| } | ||
|
|
||
| private void Write(PropertyReassignmentEventArgs e) | ||
| { | ||
| Write(BinaryLogRecordKind.PropertyReassignment); | ||
| WriteMessageFields(e); | ||
| Write(e.PropertyName); | ||
| Write(e.PreviousValue); | ||
| Write(e.NewValue); | ||
| Write(e.Location); | ||
| } | ||
| private void Write(UninitializedPropertyReadEventArgs e) | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. here as well |
||
| { | ||
| Write(BinaryLogRecordKind.UninitializedPropertyRead); | ||
| WriteMessageFields(e); | ||
| Write(e.PropertyName); | ||
| } | ||
|
|
||
| private void Write(PropertyInitialValueSetEventArgs e) | ||
| { | ||
| Write(BinaryLogRecordKind.PropertyInitialValueSet); | ||
| WriteMessageFields(e); | ||
| Write(e.PropertyName); | ||
| Write(e.PropertyValue); | ||
| Write(e.PropertySource); | ||
| } | ||
|
|
||
| private void Write(EnvironmentVariableReadEventArgs e) | ||
| { | ||
| Write(BinaryLogRecordKind.EnvironmentVariableRead); | ||
| WriteMessageFields(e); | ||
| Write(e.EnvironmentVariableName); | ||
| } | ||
|
|
||
| private void Write(CriticalBuildMessageEventArgs e) | ||
| { | ||
| Write(BinaryLogRecordKind.CriticalBuildMessage); | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| using System; | ||
|
|
||
| namespace Microsoft.Build.Framework | ||
| { | ||
| public class EnvironmentVariableReadEventArgs : BuildMessageEventArgs | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the EnvironmentVariableReadEventArgs class. | ||
| /// </summary> | ||
| #if FEATURE_BINARY_SERIALIZATION | ||
| [Serializable] | ||
| #endif | ||
| public EnvironmentVariableReadEventArgs() | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the EnvironmentVariableReadEventArgs class. | ||
| /// </summary> | ||
| public EnvironmentVariableReadEventArgs | ||
| ( | ||
| string environmentVariableName, | ||
| string message, | ||
| string helpKeyword=null, | ||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. a space on both sides of |
||
| string senderName=null, | ||
| MessageImportance importance = MessageImportance.Low, | ||
| params object[] messageArgs | ||
| ) | ||
| : base(null, null, null, 0, 0, 0, 0, message, helpKeyword, senderName, importance, DateTime.UtcNow, messageArgs) | ||
| { | ||
| EnvironmentVariableName = environmentVariableName; | ||
| } | ||
|
|
||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no two consecutive empty lines in .cs files |
||
|
|
||
| public string EnvironmentVariableName { get; set; } | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| using System; | ||
|
|
||
| namespace Microsoft.Build.Framework | ||
| { | ||
| public class PropertyInitialValueSetEventArgs : BuildMessageEventArgs | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the UninitializedPropertyRead class. | ||
| /// </summary> | ||
| #if FEATURE_BINARY_SERIALIZATION | ||
| [Serializable] | ||
| #endif | ||
| public PropertyInitialValueSetEventArgs() | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the UninitializedPropertyRead class. | ||
| /// </summary> | ||
| public PropertyInitialValueSetEventArgs | ||
| ( | ||
| string propertyName, | ||
| string propertyValue, | ||
| string propertySource, | ||
| string message, | ||
| string helpKeyword = null, | ||
| string senderName = null, | ||
| MessageImportance importance = MessageImportance.Low | ||
| ) : base(message, helpKeyword, senderName, importance) | ||
| { | ||
| this.PropertyName = propertyName; | ||
| this.PropertySource = propertySource; | ||
| this.PropertyValue = propertyValue; | ||
| } | ||
|
|
||
| public string PropertyName { get; set; } | ||
|
|
||
| public string PropertySource { get; set; } | ||
|
|
||
| public string PropertyValue { get; set; } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| using System; | ||
|
|
||
| namespace Microsoft.Build.Framework | ||
| { | ||
| public class PropertyReassignmentEventArgs : BuildMessageEventArgs | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the PropertyReassignment class. | ||
| /// </summary> | ||
| #if FEATURE_BINARY_SERIALIZATION | ||
| [Serializable] | ||
| #endif | ||
| public PropertyReassignmentEventArgs() | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Creates an instance of the PropertyReassignmentEventArgs class. | ||
| /// </summary> | ||
| /// <param name="propertyName">The name of the property whose value was reassigned.</param> | ||
| /// <param name="previousValue">The previous value of the reassigned property.</param> | ||
| /// <param name="newValue">The new value of the reassigned property.</param> | ||
| /// <param name="location">The location of the reassignment.</param> | ||
| public PropertyReassignmentEventArgs | ||
| ( | ||
| string propertyName, | ||
| string previousValue, | ||
| string newValue, | ||
| string location, | ||
| string message, | ||
| string helpKeyword = null, | ||
| string senderName = null, | ||
| MessageImportance importance = MessageImportance.Low | ||
| ) : base(message, helpKeyword, senderName, importance) | ||
| { | ||
| this.PropertyName = propertyName; | ||
| this.PreviousValue = previousValue; | ||
| this.NewValue = newValue; | ||
| this.Location = location; | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// The name of the property whose value was reassigned. | ||
| /// </summary> | ||
| public string PropertyName { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// The previous value of the reassigned property. | ||
| /// </summary> | ||
| public string PreviousValue { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// The new value of the reassigned property. | ||
| /// </summary> | ||
| public string NewValue { get; set; } | ||
|
|
||
| /// <summary> | ||
| /// The location of the reassignment. | ||
| /// </summary> | ||
| public string Location { get; set; } | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| using Microsoft.Build.Logging.StructuredLogger; | ||
| using System; | ||
|
|
||
| namespace Microsoft.Build.Framework | ||
| { | ||
| public class UninitializedPropertyReadEventArgs : BuildMessageEventArgs | ||
| { | ||
| /// <summary> | ||
| /// Initializes a new instance of the UninitializedPropertyRead class. | ||
| /// </summary> | ||
| #if FEATURE_BINARY_SERIALIZATION | ||
| [Serializable] | ||
| #endif | ||
| public UninitializedPropertyReadEventArgs() | ||
| { | ||
| } | ||
|
|
||
| /// <summary> | ||
| /// Initializes a new instance of the UninitializedPropertyRead class. | ||
| /// </summary> | ||
| public UninitializedPropertyReadEventArgs | ||
| ( | ||
| string propertyName, | ||
| string message, | ||
| string helpKeyword=null, | ||
| string senderName=null, | ||
| MessageImportance importance = MessageImportance.Low, | ||
| params object[] messageArgs | ||
| ) : base(message, helpKeyword, senderName, importance) | ||
| { | ||
| this.PropertyName = propertyName; | ||
| } | ||
|
|
||
| public string PropertyName { get; set; } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should have an empty line between methods