Skip to content

remove hardcoded RIDs#862

Merged
KirillOsenkov merged 4 commits intoKirillOsenkov:mainfrom
kasperk81:patch-2
Mar 8, 2025
Merged

remove hardcoded RIDs#862
KirillOsenkov merged 4 commits intoKirillOsenkov:mainfrom
kasperk81:patch-2

Conversation

@kasperk81
Copy link
Copy Markdown
Contributor

these are not necessary and make it work on any platform supported by runtime like linux-arm64 without hardcoding them

dotnet publish -c Release --self-contained

will publish for current RID. with -r other-rid will publish for other-rid (cross build)

@KirillOsenkov
Copy link
Copy Markdown
Owner

CI is failing

@kasperk81
Copy link
Copy Markdown
Contributor Author

ci is fixed

@KirillOsenkov
Copy link
Copy Markdown
Owner

@maxkatz6 a quick review whenever you have time

@KirillOsenkov KirillOsenkov merged commit 215883e into KirillOsenkov:main Mar 8, 2025
1 check passed
@maxkatz6
Copy link
Copy Markdown
Contributor

maxkatz6 commented Mar 9, 2025

It looks fine.
Specifically on macOS we could just build without any rid specified, and it would create an universal binary for x64 and arm64. But I don't remember if it's AOT only or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants