Add Tooltip for MSBuild Properties in Preprocess View.#875
Merged
KirillOsenkov merged 1 commit intoKirillOsenkov:mainfrom Jun 19, 2025
Merged
Conversation
| .Replace(@"$({0})=""{1}"" (", @"\$\((?<Name>\w+)\)="".*"" \(") | ||
| .Replace(@"{2}"")", @".*""\)") | ||
| .Replace(@"$({0})=""{1}"" (", @"\$\((?<Name>\w+)\)=""(?<NewValue>.*)"" \(") | ||
| .Replace(@"{2}"")", @"(?<OrgValue>.*)""\)") |
Owner
There was a problem hiding this comment.
did you mean OldValue instead of OrgValue?
Contributor
Author
There was a problem hiding this comment.
Org == Original, but Old is a better match for the 3 letter New.
| } | ||
|
|
||
| // Search the "Property reassignment" folder. | ||
| var prFolder = this.PreprocessContext.Evaluation.Children.FirstOrDefault(p => p.Title == "Property reassignment"); |
Owner
There was a problem hiding this comment.
You can use the Strings.PropertyReassignment I think
KirillOsenkov
approved these changes
Jun 19, 2025
KirillOsenkov
added a commit
that referenced
this pull request
Jun 19, 2025
Address feedbacks from #875
This was referenced Sep 1, 2025
This was referenced Sep 10, 2025
This was referenced Sep 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Tooltip for MSBuild Properties in Preprocess View.