Roll back vote_grants audit row on dispatch failure#49
Merged
Conversation
Bug introduced (in spirit) by #46 and made very visible by #48: when DispatchReward throws AFTER the audit/idempotency row was inserted, the player is permanently locked out of ever claiming that vote. Future sweeps see HasGrantForDate=true and short-circuit before retrying, even though no reward was ever actually granted. This always could have happened (e.g. SQLite glitch on AdjustPoints), but #48's VipGift dispatch made it likely — a misspelled template name in the Vote Rewards settings would silently lock out every voter on that provider. Fix: narrow try/catch around the DispatchReward call. On exception, delete the audit row via the new IVoteGrantRepository.DeleteByKey so the next sweep can retry once the admin fixes the misconfiguration. The outer try/catch (network errors during GetClaimStatus / MarkClaimed) is unaffected — those failure modes don't leave an orphaned row, so they don't need rollback. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bug fix. Caught while finishing #48 — too late to fold in there before merge.
When `DispatchReward` throws after the audit row was inserted, the player is permanently locked out of ever claiming that vote. Every future sweep sees `HasGrantForDate=true` and short-circuits, even though no reward was ever actually granted.
This always could have happened (e.g. SQLite glitch in `AdjustPoints`), but #48's VipGift dispatch made it actually likely — a misspelled template name in the Vote Rewards settings would silently lock out every voter on that provider, with no obvious way for an admin to recover other than directly editing the SQLite database.
Fix
Narrow `try/catch` around the `DispatchReward` call only. On exception:
The outer `try/catch` (network errors during `GetClaimStatus` / `MarkClaimed`) is unaffected — those failure modes don't leave an orphaned row, so they don't need rollback.
Files
Test plan
🤖 Generated with Claude Code