Settings UI polish: save-btn padding, form-row alignment, i18n key#51
Merged
Conversation
Three small fixes spotted in panel screenshots:
1. Save Settings button sat flush against the last card it followed.
Added margin-top: 1rem so it visually breathes. Applies globally
across all Settings tabs (Vote Rewards, Tickets, Discord, etc.) since
they all use the same .save-btn class within SettingsView.vue.
2. Tickets tab "Discord Integration" card showed three notification
toggles visually stacked on top of each other. Cause: .form-row was
missing align-items: center AND margin-bottom, so consecutive rows
ran flush with no vertical breathing room. .form-label's built-in
bottom margin was the only separator, which pushed the row baseline
downward instead of separating siblings. Added align-items: center
+ 0.5rem margin-bottom on .form-row, and zeroed out .form-label's
own bottom margin when nested inside a .form-row.
3. Tickets tab "Ticket System" card showed "SETTINGS.ENABLED" instead
of "Enabled" — t('settings.enabled') resolved to the literal key
because no such key exists. The "Enabled" string lives under
common.enabled. Changed the call site to match.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three small fixes spotted in panel screenshots — bundled because they're all CSS/i18n polish touching the same file.
1. Save Settings button padding
Sat flush against the last card it followed. Added `margin-top: 1rem` to `.save-btn`. Applies globally across all Settings tabs since they all use the same class within `SettingsView.vue`.
2. Form-row alignment + breathing room
Tickets tab → Discord Integration card → three notification toggles visually stacked on top of each other. Cause: `.form-row` was missing `align-items: center` AND `margin-bottom`, so consecutive rows ran flush with no vertical separation. `.form-label`'s built-in 0.35rem bottom margin was the only thing separating them, but it pushed the row baseline downward instead of cleanly separating siblings.
Fix:
3. Unresolved i18n key
Tickets tab → Ticket System card showed "SETTINGS.ENABLED" instead of "Enabled" — `t('settings.enabled')` resolved to the literal key because no such key exists. The "Enabled" string lives under `common.enabled`. Fixed the call site.
Files
Test plan
🤖 Generated with Claude Code