Skip to content

Backups: stop double-opening the SQLite connection (silent write loss) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdaInTheLab merged 1 commit into from
May 9, 2026
Merged

Backups: stop double-opening the SQLite connection (silent write loss) #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/KitsuneCommand/Services/BackupService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,15 @@ namespace KitsuneCommand.Services
/// <summary>
/// Manages world save backups: create, restore, delete, and schedule auto-backups.
/// Stores backup metadata in SQLite for the management UI.
///
/// Connection lifetime note: <see cref="DbConnectionFactory.CreateConnection"/>
/// returns an *already-opened* connection. Do NOT call <c>conn.Open()</c> again
/// inside the using block. The custom-built System.Data.SQLite that ships with
/// this mod silently drops subsequent INSERT/UPDATE statements when Open is
/// invoked twice — no exception is thrown, the controller returns 200, but no
/// row ends up in the table. (Reads happen to keep working, which is why the
/// bug went unnoticed long enough to ship a UI for the feature.) Always trust
/// the factory to return a ready-to-use connection.
/// </summary>
public class BackupService
{
Expand Down Expand Up @@ -105,7 +114,6 @@ public BackupRecord CreateBackup(string backupType = "manual", string notes = nu
// Save to database
using (var conn = _db.CreateConnection())
{
conn.Open();
Dapper.SqlMapper.Execute(conn,
@"INSERT INTO backups (filename, world_name, size_bytes, created_at, backup_type, notes)
VALUES (@Filename, @WorldName, @SizeBytes, @CreatedAt, @BackupType, @Notes)",
Expand Down Expand Up @@ -167,7 +175,6 @@ public void DeleteBackup(int backupId)
// Delete record
using (var conn = _db.CreateConnection())
{
conn.Open();
Dapper.SqlMapper.Execute(conn,
"DELETE FROM backups WHERE id = @Id",
new { Id = backupId });
Expand All @@ -181,7 +188,6 @@ public List<BackupRecord> GetAll()
{
using (var conn = _db.CreateConnection())
{
conn.Open();
return Dapper.SqlMapper.Query<BackupRecord>(conn,
"SELECT id as Id, filename as Filename, world_name as WorldName, size_bytes as SizeBytes, " +
"created_at as CreatedAt, backup_type as BackupType, notes as Notes " +
Expand All @@ -197,7 +203,6 @@ public BackupRecord GetBackup(int id)
{
using (var conn = _db.CreateConnection())
{
conn.Open();
return Dapper.SqlMapper.QueryFirstOrDefault<BackupRecord>(conn,
"SELECT id as Id, filename as Filename, world_name as WorldName, size_bytes as SizeBytes, " +
"created_at as CreatedAt, backup_type as BackupType, notes as Notes " +
Expand Down Expand Up @@ -228,8 +233,7 @@ public void LoadSettings()
{
using (var conn = _db.CreateConnection())
{
conn.Open();
var json = Dapper.SqlMapper.QueryFirstOrDefault<string>(conn,
var json = Dapper.SqlMapper.QueryFirstOrDefault<string>(conn,
"SELECT value FROM settings WHERE name = 'backup_settings'");

if (!string.IsNullOrEmpty(json))
Expand All @@ -246,7 +250,6 @@ private void SaveSettings()
{
using (var conn = _db.CreateConnection())
{
conn.Open();
var json = Newtonsoft.Json.JsonConvert.SerializeObject(_settings);
Dapper.SqlMapper.Execute(conn,
@"INSERT OR REPLACE INTO settings (name, value) VALUES ('backup_settings', @Value)",
Expand Down
Loading