Skip to content

Conversation

@williamjallen
Copy link
Collaborator

This PR completely revamps viewCoverage.php, one of only two remaining pages using XSLT. This change builds on significant work over the course of the last few months to expose the necessary data via GraphQL. The previous XSLT-based page had numerous issues which are resolved by this PR.

After:
image

Before:
image

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the revamp. Filtering seems complete ( Though I don't have function or branch coverage to test).

My only request is this:

Can we make more obvious the way to get "back" from nested directories?
The current page framework does load a "new" page on click so using the Back button is how you'd get from test/src/a to test/src. The current page lets you click into the subdirectory without updating URL parameters which means the Back button might take you to the Project page instead of the higher level directory.

Image Maybe an "Up" icon or link that appears next to these breadcrumbs when you are in a non-top level directory?

@williamjallen
Copy link
Collaborator Author

@josephsnyder What about a "back" button like this as a shortcut to the previous directory? It's worth noting that the breadcrumbs themselves are (supposed to be) clickable. While testing this some more, I found a bug with the breadcrumb navigation and I'll push a fix shortly.

image

@williamjallen williamjallen force-pushed the coverage-page-refactor branch from 991a346 to 7305da8 Compare January 5, 2026 18:00
Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that back button a lot. I wish that it could be disabled or disappear when the top level is reached, but I'll happily approve what we have.

@williamjallen
Copy link
Collaborator Author

@josephsnyder Ah, good call. I'll disable the button at the top level.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No other comments. LGTM!

@josephsnyder josephsnyder enabled auto-merge January 5, 2026 20:47
@josephsnyder josephsnyder added this pull request to the merge queue Jan 5, 2026
Merged via the queue into Kitware:master with commit 444dac8 Jan 5, 2026
7 checks passed
@williamjallen williamjallen deleted the coverage-page-refactor branch January 5, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants