Conversation
subdavis
changed the title
|
@AlmightyYakob @BryonLewis ptal: 1498285 I've automatically published to NPM as version 0.1.3 so jake can use it. Jake needs an alternative way to load an image using an object url. Hopefully this will be effective. |
There was a problem hiding this comment.
Not a complete review I need to jump to some other things. There are some issues involved with the clientSettings and the newTrackSettings. The listed changes, but then the fact that the Track Type (Both the Detection | Track| for the button name and the color of the '+' button) don't change in realtime when choosing new types or switching between track mode and Detection mode. I haven't gone through it completely yet and have to jump to some other things for a little while. But I think it might have to do with passing clientSettings.newTrackSettings to the components which will unwrap the ref automatically. Not entirely sure though because I haven't dived deeper into it.
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
This review should be completed now. Thanks for doing this and for defining a structure for separating this out.
Co-authored-by: BryonLewis <61746913+BryonLewis@users.noreply.github.com>
3 participants
https://www.npmjs.com/package/vue-media-annotator
fixes #269
fixes #273