Desktop Settings, VIAME CSV Parser, Pipeline Runner#424
Conversation
|
See #417 for screensots |
subdavis
force-pushed
the
desktop/settings
branch
from
c0e84be to
04cab1c
Compare
subdavis
changed the title
|
This PR does not include a windows implementation or even platform switching logic. However, since this thing is already huge, I'm not inclined to include those at this time. |
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
You got the core functionality there pretty quickly. The web testing went really smooth and didn't notice any effects there (obviously you didn't really touch the web side).
These are just minor things that I've noticed might need to be updated/changed. Feel free to ask me any questions about my comments, I know that they aren't always clear.
|
@BryonLewis you were right about pretty much everything except gitignore: that would exclude the assets from getting published to NPM.
FYI: |
| const coords: number[][] = []; | ||
| const polyList = poly[2].split(' '); | ||
| polyList.forEach((coord, j) => { | ||
| if (j % 2 === 0) { | ||
| // Filter out ODDs | ||
| if (polyList[j + 1]) { | ||
| coords.push([parseFloat(coord), parseFloat(polyList[j + 1])]); | ||
| } | ||
| } | ||
| }); | ||
| geoFeatureCollection.features.push(_createGeoJsonFeature('Polygon', coords)); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Just a reminder to eventually add in some better checking here for poly being an array with an even number of coordinates. (I think that should be a requirement)
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
All the fixes are tested and work well.
There is just a minor thing related to using Strings as Detection/Track Attributes. I believe right now certain values will return NaN.
BryonLewis
left a comment
BryonLewis
left a comment
There was a problem hiding this comment.
Pulled/Tested and now string based attributes show up properly.
2 participants
Adds a settings page and starts to integrate with VIAME.
fixes #432