Skip to content

Add checkbuild.sh #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
subdavis merged 3 commits into from
Nov 4, 2020
Merged

Add checkbuild.sh #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca359fd
Add checkbuild.sh
subdavis Nov 4, 2020
40f23ce
Merge branch 'master' into client/checkbuildscript
subdavis Nov 4, 2020
f3d7812
Merge branch 'master' into client/checkbuildscript
subdavis Nov 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions client/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,15 @@ yarn build:web
# build vue-media-server library
yarn build:lib

# build electron
yarn build:electron

# lint
yarn lint
yarn lint:templates

# Local verification of all tests, linting, builds
./checkbuild.sh
```

See [this issue](https://github.com/vuejs/vue-cli/issues/3065) for details on why our `yarn serve` command is weird.
Expand Down
16 changes: 16 additions & 0 deletions client/checkbuild.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
#!/bin/bash
set -e # exit immediately on fail

# This script is intended as an optional local utility.
# CI runs are expensive, so you can use this to run all
# CI Checks locally in parallel to verify that a commit will pass
# in much less time than CI would take.

yarn test &
yarn lint &
yarn lint:templates &
yarn build:web &
yarn build:electron &
yarn build:lib &

time wait
6 changes: 5 additions & 1 deletion client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,11 @@
"ts-jest": {
"tsConfig": "tsconfig.spec.json"
}
}
},
"modulePathIgnorePatterns": [
"<rootDir>/dist/",
"<rootDir>/dist_electron/"
]
Copy link
Copy Markdown
Contributor Author

@subdavis subdavis Nov 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On linux, build:electron creates a .snap package in dist_electron, which is the same file extension of a jest snapshot. The snapshot doesn't match anything and so tests fail.

},
"eslintConfig": {
"root": true,
Expand Down