Skip to content

Client/bugfix run pipelines #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
subdavis merged 1 commit into from
Nov 13, 2020
Merged

Client/bugfix run pipelines #441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion client/viame-web-common/components/RunPipelineMenu.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,13 @@ export default defineComponent({
});

const pipelinesNotRunnable = computed(() => (
props.selectedDatasetIds.length > 1 || pipelines.value === null
Copy link
Copy Markdown
Contributor Author

@subdavis subdavis Nov 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As best I can tell, this was just an uncaught typo. The logic makes no sense otherwise.

Copy link
Copy Markdown
Collaborator

@BryonLewis BryonLewis Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might of been to prevent a user from running pipelines on multiple datasets, but looks like a mistake.

props.selectedDatasetIds.length < 1 || pipelines.value === null
));

async function runPipelineOnSelectedItem(pipename: string) {
if (props.selectedDatasetIds.length === 0) {
throw new Error('No selected datasets to run on');
}
await Promise.all(
props.selectedDatasetIds.map((id) => runPipeline(id, pipename)),
);
Expand Down