fix: Jobserver.ParseNativeMakeFlagsValue test on Windows#3
Open
mayeut wants to merge 1 commit into
Open
Conversation
Author
|
Ideally, this fix could be included in a future kitware 1.13.1 release now that upstream ninja released 1.13.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the Jobserver.ParseNativeMakeFlagsValue test failure on Windows specific to the Kitware fork.
Issue found while working on scikit-build/ninja-python-distributions#305 (comment)
The fix has been tested in CI using the following diff for ninja-python-distributions: