ENH: Wrap ImageBuilding::Build2D #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewtex
reviewed
Feb 26, 2019
Collaborator
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
👍 a few inline comments
Author
|
This implementation leads to the data being copied an extra two times, to convert the b-mode data from a ManagedBuffer to a NativeBuffer in NewImageHandler::HandleNewImage (line 134) and back from a NativeBuffer to a ManagedBuffer in ContainerImpl::Build2D (line 341). Is this a performance concern? |
Build2D is used to undistort the output of a curved probe.
HastingsGreer
force-pushed
the
wrapbuild2D
branch
from
2b8c32c to
ab0c057
Compare
HastingsGreer
changed the title
thewtex
approved these changes
Feb 27, 2019
Collaborator
thewtex
left a comment
thewtex
left a comment
There was a problem hiding this comment.
Yes -- for performance, itk::ResampleImageFilter should be used instead of this function ;-).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.