Skip to content

- added scripts#10

Merged
josephbirkner merged 4 commits intoKlebert-Engineering:mainfrom
neel:main
Feb 22, 2024
Merged

- added scripts#10
josephbirkner merged 4 commits intoKlebert-Engineering:mainfrom
neel:main

Conversation

@neel
Copy link
Contributor

@neel neel commented Feb 21, 2024

  • added SCRIPTS
  • added EMAIL
add_wheel(my_lib
  EMAIL "email@address.com"
  ...
  SCRIPTS
    /path/to/python/script
)

Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks great overall, I would be very happy to merge this. Can you take a look at my comment?

Edit: Also, can you add the new EMAIL and SCRIPTS options to the function documentation of add_wheel in the README and in the code?

Copy link
Contributor Author

@neel neel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fixed

@josephbirkner josephbirkner self-requested a review February 22, 2024 11:01
Copy link
Collaborator

@josephbirkner josephbirkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🥳

@josephbirkner josephbirkner merged commit 9c3ab69 into Klebert-Engineering:main Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants