Introduce generic Model::resolve<Target>#135
Merged
josephbirkner merged 2 commits intov0.6.3from Feb 12, 2026
Merged
Conversation
johannes-wolf
requested changes
Feb 9, 2026
|
|
johannes-wolf
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This PR fixes #99 by introducing and ADL-based
Model::resolve(ModelNode|model_ptr|ModelNodeAddress)interface.Note
Medium Risk
Touches core node-resolution and casting pathways and introduces template/ADL-based dispatch, which could cause subtle compile/link or runtime type-mismatch issues if downstream models don’t provide the expected
resolveInternalhooks.Overview
Introduces a generic
Model::resolve<Target>overload set that can resolve fromModelNodeAddress,ModelNode, ormodel_ptr, delegating typed casts to an ADL customization pointresolveInternal(tag, model, node); debug builds assert model/type compatibility while release builds avoid RTTI.Reworks core typed resolution by deleting
ModelPool::resolveObject/resolveArrayand providing built-inresolveInternalspecializations forObjectandArray, plus small supporting refactors (ModelPoolre-exposes base overloads viausing Model::resolve,BaseObjectuses a shareddetail::ObjectFieldstorage type, andProceduralObjectdefinesModelTypefor compatibility).Written by Cursor Bugbot for commit 6b01ea8. This will update automatically on new commits. Configure here.