Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 22. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
|
|
include/simfil/model/arena.h
Outdated
|
|
||
| Chunk& updatedLast = ensure_capacity_and_get_last_chunk(a); | ||
| #ifdef ARRAY_ARENA_THREAD_SAFE | ||
| std::shared_lock guard(lock_); |
There was a problem hiding this comment.
I think we need to acquire a write lock here.
include/simfil/model/arena.h
Outdated
| return compactHeads_.has_value(); | ||
| } | ||
|
|
||
| [[nodiscard]] bool isCompact() const { |
There was a problem hiding this comment.
Remove this duplicate.
|
|




Changes:
TwoPart<First, Second>storage support forModelColumn/ArrayArena.Benchmark results: