Port to 1.20.1 #54
Merged
Port to 1.20.1 #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KnightMiner
reviewed
Oct 5, 2024
| // advanced tea | ||
| addTea(consumer, cup_cocoa, Items.COCOA_BEANS, Items.COCOA_BEANS, teapot_frothed); | ||
| addHoney(consumer, cup_cocoa, tea_stick, CocoaItem.CINNAMON_TAG); | ||
| addHoney(consumer, RecipeCategory.MISC, cup_cocoa, tea_stick, CocoaItem.CINNAMON_TAG); |
Owner
There was a problem hiding this comment.
I feel like most of the tea crafting recipes should be under food.
The pots themselves I think misc is reasonable, I could go either way on the tea bags and water boiling and alike as long as its consistent. But anything that is edible I'd put under food.
KnightMiner
reviewed
Oct 5, 2024
| private final String tag; | ||
| public ShapelessHoneyRecipe(ResourceLocation id, String group, ItemLike tea, Ingredient honey, String tag) { | ||
| super(id, group, TeaCupItem.withHoney(new ItemStack(tea), tag), NonNullList.of(Ingredient.EMPTY, Ingredient.of(tea), honey)); | ||
| super(id, group, CraftingBookCategory.MISC, TeaCupItem.withHoney(new ItemStack(tea), tag), NonNullList.of(Ingredient.EMPTY, Ingredient.of(tea), honey)); |
Owner
There was a problem hiding this comment.
Food also makes more sense for this category; arguably should be just passed in from JSON however shapeless recipes do it if thats not too much effort.
Contributor
Author
There was a problem hiding this comment.
CraftingBookCategory only has 4 values: BUILDING, REDSTONE, EQUIPMENT and MISC
KnightMiner
reviewed
Oct 5, 2024
src/main/java/knightminer/simplytea/data/gen/WorldgenGenerator.java
Outdated
Show resolved
Hide resolved
Owner
|
Mostly looks good, just a couple of minor comments. |
KnightMiner
added
compatibility
1.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the mod to 1.20.1
Happy ModToberFest :)