Add support for retrieving a single notification info using his ID#489
Add support for retrieving a single notification info using his ID#489Nyholm merged 11 commits intoKnpLabs:masterfrom m1guelpf:patch-1
Conversation
| public function id($id) | ||
| { | ||
| if (!is_numeric($id)) { | ||
| // Error |
There was a problem hiding this comment.
What do I do here?
There was a problem hiding this comment.
It's okey if you remove this if statement. If someone uses a string they will get a 404 back.
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
I like this feature. Good work!
| $this->put('/notifications', $parameters); | ||
| } | ||
| /** | ||
| * [UNDOCUMENTED] Gets a single notification using his ID |
There was a problem hiding this comment.
It isn't in this library documentation
There was a problem hiding this comment.
I suggest to remove "[UNDOCUMENTED]" and add some documentation instead =)
| * | ||
| * @link https://developer.github.com/v3/activity/notifications/#view-a-single-thread | ||
| * | ||
| * @param ID|integer $id |
| public function id($id) | ||
| { | ||
| if (!is_numeric($id)) { | ||
| // Error |
There was a problem hiding this comment.
It's okey if you remove this if statement. If someone uses a string they will get a 404 back.
|
@Nyholm Done |
|
@Nyholm Merge? |
|
I do not have push permission to this repo. (I would be happy if I was granted that though) We have to wait until @cursedcoder reviews this. Im sure he will not find any issues. |
|
@Nyholm just sent you an invitation |
|
Thank you @cursedcoder And thank you @m1guelpf for the PR. |
3 participants
Fix #488
Add support for retrieving a single notification info using his ID.