Use the new cache plugin factory method#531
Merged
Nyholm merged 2 commits intoKnpLabs:masterfrom Mar 28, 2017
Merged
Conversation
Closed
Nyholm
approved these changes
Mar 23, 2017
Collaborator
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Can this be merged as soon as 1.3 is tagged?
Collaborator
Author
|
@Nyholm yes! |
Collaborator
|
Good. Im just waiting on some input form Tuupola on the cache plugin. I'll make sure to tag it after I heard from him. |
Collaborator
Author
|
That's good, thanks! |
Nyholm
requested changes
Mar 23, 2017
Collaborator
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
We should also update composer to use
php-http/cache-plugin:^1.3
acrobat
force-pushed
the
cache-plugin-update
branch
from
08db915 to
c8003da
Compare
Collaborator
Author
|
👍 Fixed @Nyholm |
Closed
Nyholm
approved these changes
Mar 28, 2017
Collaborator
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Cache plugin 1.3 is released. Just waiting for travis now.
Collaborator
|
Thank you @acrobat for your contributions! |
Collaborator
Author
|
🎉 thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr updates the addCache method so we use the new factory method introduced in php-http/cache-plugin#26. This way the caching of github requests will work again. Fixes #502
DO NOT MERGE! This can only be merged after a release of the php-http/cache-plugin (v1.3.0). But like you asked @Nyholm in php-http/cache-plugin#26 (comment)