Semicircle (concave/convex) shaped piechart slices#125
Conversation
- Concave/convex semicircle shaped endings - Nearly exact API as DefaultSlice except doesn't accept BorderStroke - Gaps can lead to negative sweep angles which cause rendering issues; only rendering positive angles
|
Ohhh, I just saw there's a copyright tag in the source code which originates from my default Android Studio settings. I'll remove this in a few minutes. |
gsteckman
left a comment
gsteckman
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Please run detekt and correct any code style errors it finds. Expanding on hover does not produce a nice effect, in my opinion...maybe it should be disabled for this type of slice shape? Another option could be to make it thicker on hover. That might look ok, given a big enough hole size.
- adding gap argument comment - extracting inner circle sweep angle constant - slices don't expand on hover event - fixing detekt's argument number constraint by introducing parameter data classes - gap cannot be negative `require` constraint
|
2 participants
Motivation
When I was looking for a CMP chart library I needed to keep style specifications in mind which are established in an app I'm currently working on. One of these are rounded slices in pie charts. I've first encountered this functionality when I was using MPAndroidChart.
Since koalaplot has been designed with a straighforward approach of providing custom rendering, providing a
Shapeimplementation was relatively easy but at the same time none-trivial. This is why I think it is best to share this addition with everyone.Description
DefaultSliceexcept doesn't acceptBorderStrokeThe following screenshot illustrates the basic thought behind this feature.
Current limitations
To reduce mental load, I'm using 3 distinct paths which are finally combined with
addPath. This however treats them as 3 seperate paths, which causes issues whenBorderStrokeis applied, which is why I decided to abandon this for the moment.