Update to use no-std-compat#3
Open
jD91mZM2 wants to merge 4 commits intoKodrAus:mainfrom
Open
Conversation
KodrAus
reviewed
Aug 28, 2019
Owner
KodrAus
left a comment
KodrAus
left a comment
There was a problem hiding this comment.
Hi @jD91mZM2 👋
Thanks for the PR! I like the idea of no-std-compat, especially bringing alloc more into the current layering of core and std (right now alloc isn't just core + collections).
I'd like to spend a little time playing with no-std-compat to see how IDE tooling handles resolving items back to std and think about how upstream changes could be managed in direct and transitive dependencies (perhaps you could look at a nightly run of generate.py and issue a compile warning using a build.rs if the user's toolchain doesn't match the one you generated from?) Relying on rust-src to be available when compiling would be a bit problematic.
Author
|
Oof, thank god for CIs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per request of https://gitlab.com/jD91mZM2/no-std-compat/issues/2#note_207655557