Scope KOMPUTE_BUILD_PYTHON to Python module and fix fmt include in Tensor.cpp#464
Closed
eunos-1128 wants to merge 1 commit intoKomputeProject:masterfrom
Closed
Scope KOMPUTE_BUILD_PYTHON to Python module and fix fmt include in Tensor.cpp#464eunos-1128 wants to merge 1 commit intoKomputeProject:masterfrom
KOMPUTE_BUILD_PYTHON to Python module and fix fmt include in Tensor.cpp#464eunos-1128 wants to merge 1 commit intoKomputeProject:masterfrom
Conversation
eunos-1128
changed the title
eunos-1128
changed the title
KOMPUTE_BUILD_PYTHON to Python module and fix fmt include in Tensor.cpp
…nclude in Tensor.cpp Signed-off-by: UENO, M. <eunosium-1128@live.jp>
eunos-1128
force-pushed
the
fix/conda-packageing
branch
from
f23fd66 to
63608a3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issues discovered during conda packaging.
It scopes the
KOMPUTE_BUILD_PYTHONcompile definition to the Python module target only, fixes incorrectly mapped logging macros inLogger.hppfor Python builds, and adds missing fmt library includes inManager.cppandTensor.cpp.This pull request makes targeted improvements to how the Python build option is handled and updates an include in the
Tensor.cppsource file. The main changes are:Build configuration improvements:
KOMPUTE_BUILD_PYTHONso that it is now only set for the Python module build, rather than globally for all builds. This is done by removing the definition from the mainCMakeLists.txtand adding it specifically to the Python module'sCMakeLists.txtusingtarget_compile_definitions. [1] [2]Source file update:
fmt/format.hheader include tosrc/Tensor.cpp, likely to support new or existing formatting functionality.