Merged
Conversation
programmer04
approved these changes
Sep 13, 2023
|
If we're removing the workflow, shouldn't we delete its config as well? https://github.com/Kong/httpbin/blob/main/.pre-commit-config.yaml As I can see in general it was meant to run some linting - do we have something in its place? |
|
BTW won't this workflow be synced again anyway? The comment says:
Edit: ok, it shouldn't as this repo is not mentioned in the Kong/template-generic config. |
Member
Author
|
It won't because it's not in https://github.com/Kong/template-generic/blob/main/.github/template-sync.yml But I believe I can fix it. Let me try #37 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/pre-commit/action is in maintenance mode and has been failing for a while now.
This PR removes it.