Merged
Conversation
|
|
Adding the HOME variable makes the Docker build process create and use the /httpbin/.local folder in both build and runtime. Without this, the Dockerfile creates a folder /root/.local and uses it while the specified user is root. However, in the case of a user override with runAsUser or a similar command, /root is no longer the home directory and is not accessible to the non-root user. This line fixes this issue. It has been fixed and tested locally.
VBranimir
force-pushed
the
fix/62-file-location-and-ownership
branch
from
8740ebb to
d1d2bf4
Compare
pmalek
approved these changes
Oct 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build process creates /root/.local folder but for running as non root (and maybe some similar usecases) it would be best in my opinion that the virtualenvs resides under the workdir /httpbin e.g. /httpbin/.local/.../virtualenvs/
This one line fixes my usage of runAsUser
This is also related and should solve the root cause of both issue 60 and issue 62.
Summary
Adding the HOME variable makes the Docker build process create and use the /httpbin/.local folder in both build and runtime. Without this, the Dockerfile creates a folder /root/.local and uses it while the specified user is root. However, in the case of a user override with runAsUser or a similar command, /root is no longer the home directory and is not accessible to the non-root user. This line fixes this issue. It has been fixed and tested locally.
Full changelog
Dockerfile
Issues resolved
Fix 60, 62
Documentation
Testing
Test results:
TEST 1: Reproducing the
Permission denied: '/.local'issueTest 2: Reproducing the
Error: the command gunicorn could not be found within PATH or Pipfile's [scripts].Test 3: After fix
