Skip to content

bump electron 28#24

Merged
jackkav merged 5 commits intodevelopfrom
bump/electron-28
Dec 20, 2023
Merged

bump electron 28#24
jackkav merged 5 commits intodevelopfrom
bump/electron-28

Conversation

@jackkav
Copy link
Copy Markdown

@jackkav jackkav commented Dec 18, 2023

python 3.12 deprecated distutils, node-gyp, nan, electron-mocha had required bumps to formally support the change
nodejs/node-gyp#2869
jprichardson/electron-mocha#207

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@1620bac). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #24   +/-   ##
==========================================
  Coverage           ?   93.51%           
==========================================
  Files              ?       44           
  Lines              ?      940           
  Branches           ?       97           
==========================================
  Hits               ?      879           
  Misses             ?       41           
  Partials           ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackkav jackkav requested a review from a team December 18, 2023 16:05
@jackkav jackkav merged commit 326c50e into develop Dec 20, 2023
@jackkav jackkav deleted the bump/electron-28 branch December 20, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants