Skip to content

fix(curl): revert to use openssl on macos [INS-3445]#27

Merged
notjaywu merged 2 commits intodevelopfrom
fix/macos-openssl
Jan 11, 2024
Merged

fix(curl): revert to use openssl on macos [INS-3445]#27
notjaywu merged 2 commits intodevelopfrom
fix/macos-openssl

Conversation

@notjaywu
Copy link
Copy Markdown

@notjaywu notjaywu commented Dec 28, 2023

We changed to use SecureTransport in the last release to access the keychain on macOS.

But it causes some regressions:

  1. #6948
  2. #6946

Using SecureTransport allows us to support Mac Keychain but we lose support for TLS 1.3 and client certificates cannot be directly uploaded into the app.

Using other solutions like OpenSSL, allows us to support TLS 1.3 and client certificates in the app, but we lose access to the MacOS Keychain.

But MacOS Keychain certificates could be imported into Insomnia if we supported OpenSSL (you would have them in two places, Insomnia + Keychain).

So the best solution is to support OpenSSL, and ask the user to re-import the client certificates they want to use inside Insomnia. We lose a native integration with Keychain, which will cause poor UX, but will not cause a loss of capability. Whereas supporting SecureTransport has better UX, but at a greater cost of loss of capability.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@326c50e). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #27   +/-   ##
==========================================
  Coverage           ?   93.51%           
==========================================
  Files              ?       44           
  Lines              ?      940           
  Branches           ?       97           
==========================================
  Hits               ?      879           
  Misses             ?       41           
  Partials           ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@notjaywu notjaywu changed the title [wip] fix(curl): revert to use openssl on macos fix(curl): revert to use openssl on macos [INS-3445] Jan 11, 2024
@notjaywu notjaywu requested a review from jackkav January 11, 2024 03:25
@notjaywu notjaywu self-assigned this Jan 11, 2024
@notjaywu notjaywu added the bug label Jan 11, 2024
@notjaywu notjaywu marked this pull request as ready for review January 11, 2024 03:41
@notjaywu notjaywu merged commit e1377eb into develop Jan 11, 2024
@notjaywu notjaywu deleted the fix/macos-openssl branch January 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants