fix(curl): revert to use openssl on macos [INS-3445]#27
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #27 +/- ##
==========================================
Coverage ? 93.51%
==========================================
Files ? 44
Lines ? 940
Branches ? 97
==========================================
Hits ? 879
Misses ? 41
Partials ? 20 ☔ View full report in Codecov by Sentry. |
jackkav
approved these changes
Jan 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We changed to use SecureTransport in the last release to access the keychain on macOS.
But it causes some regressions:
Using SecureTransport allows us to support Mac Keychain but we lose support for TLS 1.3 and client certificates cannot be directly uploaded into the app.
Using other solutions like OpenSSL, allows us to support TLS 1.3 and client certificates in the app, but we lose access to the MacOS Keychain.
But MacOS Keychain certificates could be imported into Insomnia if we supported OpenSSL (you would have them in two places, Insomnia + Keychain).
So the best solution is to support OpenSSL, and ask the user to re-import the client certificates they want to use inside Insomnia. We lose a native integration with Keychain, which will cause poor UX, but will not cause a loss of capability. Whereas supporting SecureTransport has better UX, but at a greater cost of loss of capability.