Skip to content

Bump/electron-29#34

Merged
jackkav merged 11 commits intodevelopfrom
bump/electron-29
Apr 4, 2024
Merged

Bump/electron-29#34
jackkav merged 11 commits intodevelopfrom
bump/electron-29

Conversation

@jackkav
Copy link
Copy Markdown

@jackkav jackkav commented Mar 25, 2024

had to move setup node until after brew installs because brew was overwriting the node version
also had to solve a c++ macro conflict in every .cc file

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@2644418). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #34   +/-   ##
==========================================
  Coverage           ?   93.51%           
==========================================
  Files              ?       44           
  Lines              ?      940           
  Branches           ?       97           
==========================================
  Hits               ?      879           
  Misses             ?       41           
  Partials           ?       20           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jackkav jackkav merged commit b03383d into develop Apr 4, 2024
@jackkav jackkav deleted the bump/electron-29 branch April 4, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants