Skip to content

Feature/ins-4917-set-up-linux-arm-build-to-support-flatpak#82

Merged
filfreire merged 9 commits intodevelopfrom
feature/ins-4917-set-up-linux-arm-build-to-support-flatpak
Jan 23, 2025
Merged

Feature/ins-4917-set-up-linux-arm-build-to-support-flatpak#82
filfreire merged 9 commits intodevelopfrom
feature/ins-4917-set-up-linux-arm-build-to-support-flatpak

Conversation

@jackkav
Copy link
Copy Markdown

@jackkav jackkav commented Jan 20, 2025

In order to support Kong/insomnia#8306

@hexchain
Copy link
Copy Markdown

hexchain commented Jan 21, 2025

I've made some progress here: feature/ins-4917-set-up-linux-arm-build-to-support-flatpak...hexchain:node-libcurl:linux-aarch64-test

It builds successfully but some test fails (for both x86_64 and aarch64 though). Feel free to take.

Comment thread .github/workflows/build-lint-test.yaml Outdated
@hexchain
Copy link
Copy Markdown

hexchain commented Jan 22, 2025

I think those tests fail because the test URL, http://example.com, does not accpet PUT requests anymore (assuming it worked before), so the callbacks for file uploads never get a chance to execute because curl won't be expecting a body.

As a simple PoC test, I added curl.setOpt('URL', 'http://httpbin.org/put') to those tests and all of them passed.

Comment thread test/curl/easy.spec.ts Outdated
@filfreire filfreire merged commit d5035fa into develop Jan 23, 2025
@filfreire filfreire deleted the feature/ins-4917-set-up-linux-arm-build-to-support-flatpak branch January 23, 2025 11:34
@filfreire
Copy link
Copy Markdown

Triggered 2.33.5 release to include this change

@filfreire
Copy link
Copy Markdown

The build release job fails for Linux ARM with:

make: Entering directory '/home/runner/work/node-libcurl/node-libcurl/build'
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  CC(target) Release/obj.target/sslctx/src/sslctx.o
cc: error: unrecognized command-line option '-m64'
make: *** [sslctx.target.mk:118: Release/obj.target/sslctx/src/sslctx.o] Error 1
make: Leaving directory '/home/runner/work/node-libcurl/node-libcurl/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants