Skip to content

refactor: use @kong-ui-public/monaco-editor#184

Open
arashsheyda wants to merge 8 commits into
mainfrom
refactor/kong-monaco-editor
Open

refactor: use @kong-ui-public/monaco-editor#184
arashsheyda wants to merge 8 commits into
mainfrom
refactor/kong-monaco-editor

Conversation

@arashsheyda
Copy link
Copy Markdown
Member

description

this PR updates the usage of MonacoEditor by using the component from @kong-ui-public/monaco-editor

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 7, 2026

Deploy Preview for kong-spec-editor ready!

Name Link
🔨 Latest commit ed78e0c
🔍 Latest deploy log https://app.netlify.com/projects/kong-spec-editor/deploys/699f69aea835ff00080c2194
😎 Deploy Preview https://deploy-preview-184--kong-spec-editor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@arashsheyda
Copy link
Copy Markdown
Member Author

arashsheyda commented Jan 7, 2026

I'm seeing a weird issue with shiki where we need to install @shikijs/core @shikijs/engine-javascript @shikijs/langs @shikijs/monaco @shikijs/themes inorder it to work! which shouldn't be the case since we're installing shiki 🤔

@arashsheyda
Copy link
Copy Markdown
Member Author

so it turns out we didn't have shamefully-hoist=true in .npmrc, that's why it failed. thanks to @kingyue737 for the save!

Comment thread package.json
@arashsheyda arashsheyda added the do not merge Please don't merge this Pull Request label Feb 25, 2026
@kongponents-bot
Copy link
Copy Markdown
Collaborator

🔴 PR audit failed. 🔴

🔥 PNPM Audit issues detected.

┌─────────────────────┬────────────────────────────────────────────────────────┐
│ high                │ minimatch has a ReDoS via repeated wildcards with      │
│                     │ non-matching literal in pattern                        │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Package             │ minimatch                                              │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Vulnerable versions │ <3.1.3                                                 │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Patched versions    │ >=3.1.3                                                │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Paths               │ .>commitizen>glob>minimatch                            │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ More info           │ https://github.com/advisories/GHSA-3ppc-4f35-3m26      │
└─────────────────────┴────────────────────────────────────────────────────────┘
┌─────────────────────┬────────────────────────────────────────────────────────┐
│ high                │ minimatch has a ReDoS via repeated wildcards with      │
│                     │ non-matching literal in pattern                        │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Package             │ minimatch                                              │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Vulnerable versions │ >=9.0.0 <9.0.6                                         │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Patched versions    │ >=9.0.6                                                │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ Paths               │ .>@kong/eslint-config-kong-ui>typescript-              │
│                     │ eslint>@typescript-eslint/typescript-estree>minimatch  │
│                     │                                                        │
│                     │ .>@vue/test-utils>js-beautify>editorconfig>minimatch   │
├─────────────────────┼────────────────────────────────────────────────────────┤
│ More info           │ https://github.com/advisories/GHSA-3ppc-4f35-3m26      │
└─────────────────────┴────────────────────────────────────────────────────────┘
2 vulnerabilities found
Severity: 2 high

PR with those issues cannot be merged.

How to resolve:

  • Check open renovate PRs for updates to the dependencies mentioned in the audit report
  • try to update dependencies listed in the audit report to the latest versions
  • use pnpm audit --fix to automatically fix issues

🔥 No test coverage detected.

This PR does not include any test coverage changes, but it modifies source code. Please add appropriate tests to cover the changes made in this PR.

If you believe this is a false positive or if there are valid reasons for not including test coverage changes, please request an exemption by adding the test-coverage-exempt label to the PR and ensure it is approved by one of those managers jillztom, nateslo, erichsend, lahabana, hangrao, ryanmoore, elen4, DaniellaFreese, mfollett, ValeryG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Please don't merge this Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants