fix(schema-model): improve logic for resolving circular refs and use when removing readonly fields#810
Draft
vaibhavrajsingh2001 wants to merge 6 commits into
Draft
Conversation
…when removing readonly fields
Contributor
Author
adamdehaven
reviewed
Mar 6, 2026
Member
adamdehaven
left a comment
There was a problem hiding this comment.
We need to find what's actually throwing the error and properly catch it. It looks like there are still 500 errors during SSR in the portal
Collaborator
Install the preview package from this PR@kong/spec-renderer@pr-810 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some specs with circular refs in Schema Objects were failing parsing.
Reason:
removeFieldsFromSchemaObjectpreviously relied onJSON.parse(JSON.stringify)cloning, which fails for circular refs.Changes:
removeFieldsFromSchemaObjectthen resolve circular refsWeakMap,removeFieldsFromSchemaObjectPortal verification PR: https://github.com/kong-konnect/portal/pull/2097