Skip to content

Fix IT note fades, compressed stereo samples, approximate command \xx#64

Merged
Konstanty merged 4 commits intoKonstanty:masterfrom
sagamusix:master
Jan 28, 2022
Merged

Fix IT note fades, compressed stereo samples, approximate command \xx#64
Konstanty merged 4 commits intoKonstanty:masterfrom
sagamusix:master

Conversation

@sagamusix
Copy link
Contributor

If people keep using the library, might as well fix the most blatantly missing IT features to make modern IT tracks lightly more listenable: Compressed stereo samples and note fades. As a bonus, OpenMPT command \xx (Smooth MIDI Macro) is now imported as command Zxx (MIDI macro).

@sagamusix
Copy link
Contributor Author

@sezero maybe you want to add these to your fork

@sezero
Copy link
Contributor

sezero commented Jan 11, 2022

@sezero maybe you want to add these to your fork

Thanks. There are conflicts though, will try resolving them.

sezero pushed a commit to sezero/libmodplug that referenced this pull request Jan 11, 2022
sezero pushed a commit to sezero/libmodplug that referenced this pull request Jan 11, 2022
sezero pushed a commit to sezero/libmodplug that referenced this pull request Jan 11, 2022
@sezero
Copy link
Contributor

sezero commented Jan 11, 2022

@sezero maybe you want to add these to your fork

I resolved the conflicts (which were mostly due to Alice's fuzz fixes patchset)
and applied these patches. @AliceLR, @sagamusix: Do you see any brokenness
with sezero@bc39ec6, just in case?

@AliceLR
Copy link
Contributor

AliceLR commented Jan 12, 2022

I resolved the conflicts (which were mostly due to Alice's fuzz fixes patchset) and applied these patches. @AliceLR, @sagamusix: Do you see any brokenness with sezero@bc39ec6, just in case?

It looks like your patch shouldn't break the fuzz patch changes.

If people keep using the library

I think the license pretty much guarantees this—SDL_sound and SDL_mixer both use libmodplug explicitly because it's more permissive than their zlib license and they link it statically.

@sagamusix
Copy link
Contributor Author

I think the license pretty much guarantees this—SDL_sound and SDL_mixer both use libmodplug explicitly because it's more permissive than their zlib license and they link it statically.

The fact that they (IIRC) use their own version ported to C doesn't make it any better 😭

sezero added a commit to icculus/SDL_sound that referenced this pull request Jan 13, 2022
Fix IT note fades, compressed stereo samples, approximate command \xx.
Konstanty/libmodplug#64
sezero added a commit to libsdl-org/SDL_mixer that referenced this pull request Jan 13, 2022
Fix IT note fades, compressed stereo samples, approximate command \xx.
Konstanty/libmodplug#64
@Konstanty Konstanty merged commit 78aac87 into Konstanty:master Jan 28, 2022
sezero added a commit to sezero/libmodplug that referenced this pull request Jan 28, 2022
sezero added a commit to sezero/libmodplug that referenced this pull request Jan 28, 2022
Konstanty added a commit that referenced this pull request Jan 28, 2022
load_it: fix bad merge of PR #64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants