Fuzz patch 1 original#67
Merged
Konstanty merged 52 commits intoKonstanty:oob_read_fixesfrom Jan 28, 2022
Merged
Conversation
Owner
Konstanty
commented
Jan 28, 2022
Konstanty
commented
- Experimenting merging on existing fuzz fixes.
* Fix out-of-bounds reads in the DSMI AMF loader caused by missing order list bounds checks. * Fix out-of-bounds reads in the FAR loader caused by not correctly bounding the maximum pattern read size. * Fix out-of-bounds reads in the IT sample decompressors caused by allowing ITReadBits to read past the end of the sample buffer. * Fix out-of-bounds reads in the MED loader caused by the MMD2PLAYSEQ table bounds check not including the size of the offset being read. * Fix out-of-bounds reads in the MIDI loader caused by no bounds checks being performed on the mmread* and mid_read* functions. * Fix leaks in the MIDI loader caused by not freeing MIDTRACKs. * Fix leak and hangs in the MIDI loader caused by not releasing the MIDI structs and reentry flag when m_nChannels is 0. * Fix out-of-bounds reads in the OKT loader caused by numerous bounds checks not correctly including the size of the data being read. * Fix out-of-bounds reads in the PSM loader caused by dereferencing (PSMCHUNK *)lpStream before any bounds checks. * Fix out-of-bounds reads in the S3M loader due to various absent bounds checks. * Fix out-of-bounds reads in the ULT loader due to incorrect event bounding. * Fix out-of-bounds reads in the XM loader due to not including the size of XMINSTRUMENTHEADER in the XMSAMPLEHEADER bounds check.
This was referenced Jan 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.