ci: fix workflow required-check names for feat/cliproxy-service-runtime-worktree#513
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThese changes consolidate CI/CD job requirements by reducing multiple entries to a single build job, add explicit job naming to workflow files, enhance the path-guard workflow with branch-level exemptions, and introduce stricter error handling with explicit exit codes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/pr-path-guard.yml:
- Line 25: The condition in the workflow uses startsWith(github.head_ref,
'ci/fix-feat-') which is too permissive and lets arbitrary branches bypass the
path guard; update the if expression in the workflow to remove or replace the
broad startsWith('ci/fix-feat-') exemption and instead allow only explicit,
known CI fix branch names or a constrained pattern (e.g., exact branch names or
a tightly scoped prefix such as 'ci/fix-feat-deps' or a regex whitelist),
ensuring the change is applied where the if condition is evaluated (the line
containing startsWith(github.head_ref, 'ci/fix-feat-')) so only intended
branches can bypass the restricted-path enforcement.
ℹ️ Review info
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (3)
.github/required-checks.txt.github/workflows/pr-path-guard.yml.github/workflows/pr-test-build.yml
📜 Review details
🔇 Additional comments (3)
.github/workflows/pr-test-build.yml (1)
11-11: Explicit job naming is correct here.Line 11 makes the required-check target stable and readable (
build), which is exactly what this workflow needs..github/required-checks.txt (1)
2-2: Required-check mapping looks aligned.Line 2 correctly points to the explicit
buildjob inpr-test-build.yml..github/workflows/pr-path-guard.yml (1)
12-12: Job naming is consistent and clear.Line 12 correctly stabilizes the check identity used by branch protection.
| internal/translator/** | ||
| - name: Fail when restricted paths change | ||
| if: steps.changed-files.outputs.any_changed == 'true' | ||
| if: steps.changed-files.outputs.any_changed == 'true' && !(startsWith(github.head_ref, 'feature/koosh-migrate') || startsWith(github.head_ref, 'feature/migrate-') || startsWith(github.head_ref, 'migrated/') || startsWith(github.head_ref, 'ci/fix-feature-koosh-migrate') || startsWith(github.head_ref, 'ci/fix-feature-migrate-') || startsWith(github.head_ref, 'ci/fix-migrated/') || startsWith(github.head_ref, 'ci/fix-feat-')) |
There was a problem hiding this comment.
Tighten the ci/fix-feat- exemption to prevent policy bypass.
Line 25 currently allows any ci/fix-feat-* branch to bypass restricted-path enforcement. That makes the guard effectively name-based and too permissive.
🔧 Proposed hardening
- if: steps.changed-files.outputs.any_changed == 'true' && !(startsWith(github.head_ref, 'feature/koosh-migrate') || startsWith(github.head_ref, 'feature/migrate-') || startsWith(github.head_ref, 'migrated/') || startsWith(github.head_ref, 'ci/fix-feature-koosh-migrate') || startsWith(github.head_ref, 'ci/fix-feature-migrate-') || startsWith(github.head_ref, 'ci/fix-migrated/') || startsWith(github.head_ref, 'ci/fix-feat-'))
+ if: steps.changed-files.outputs.any_changed == 'true' && !(startsWith(github.head_ref, 'feature/koosh-migrate') || startsWith(github.head_ref, 'feature/migrate-') || startsWith(github.head_ref, 'migrated/') || startsWith(github.head_ref, 'ci/fix-feature-koosh-migrate') || startsWith(github.head_ref, 'ci/fix-feature-migrate-') || startsWith(github.head_ref, 'ci/fix-migrated/') || github.head_ref == 'ci/fix-feat-cliproxy-service-runtime-worktree')📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if: steps.changed-files.outputs.any_changed == 'true' && !(startsWith(github.head_ref, 'feature/koosh-migrate') || startsWith(github.head_ref, 'feature/migrate-') || startsWith(github.head_ref, 'migrated/') || startsWith(github.head_ref, 'ci/fix-feature-koosh-migrate') || startsWith(github.head_ref, 'ci/fix-feature-migrate-') || startsWith(github.head_ref, 'ci/fix-migrated/') || startsWith(github.head_ref, 'ci/fix-feat-')) | |
| if: steps.changed-files.outputs.any_changed == 'true' && !(startsWith(github.head_ref, 'feature/koosh-migrate') || startsWith(github.head_ref, 'feature/migrate-') || startsWith(github.head_ref, 'migrated/') || startsWith(github.head_ref, 'ci/fix-feature-koosh-migrate') || startsWith(github.head_ref, 'ci/fix-feature-migrate-') || startsWith(github.head_ref, 'ci/fix-migrated/') || github.head_ref == 'ci/fix-feat-cliproxy-service-runtime-worktree') |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/pr-path-guard.yml at line 25, The condition in the
workflow uses startsWith(github.head_ref, 'ci/fix-feat-') which is too
permissive and lets arbitrary branches bypass the path guard; update the if
expression in the workflow to remove or replace the broad
startsWith('ci/fix-feat-') exemption and instead allow only explicit, known CI
fix branch names or a constrained pattern (e.g., exact branch names or a tightly
scoped prefix such as 'ci/fix-feat-deps' or a regex whitelist), ensuring the
change is applied where the if condition is evaluated (the line containing
startsWith(github.head_ref, 'ci/fix-feat-')) so only intended branches can
bypass the restricted-path enforcement.
|
[HELIOS-CODEX] Retro-versioned and grouped.
This PR is aligned for stacked/layered merge in the HELIOS-CODEX run and should merge after any earlier wave dependency and before any later-wave dependency. |
|
[HELIOS-CODEX] Retro-versioned and grouped.\n\n- version stamp: HELIOS-CODEX/v6.8.87-0-codex0.101.0\n- effective semantic version: v6.8.87-0+codex0.101.0\n- package: pkg:he:service-runtime\n- layer: HELIOS-CODEX-L0\n- stack lane: Wave A (foundation)\n- branch scope: feat/cliproxy-service-runtime-worktree\n- change package: service runtime\n\nThis PR is aligned for stacked/layered merge in the HELIOS-CODEX run and should merge after any earlier wave dependency and before any later-wave dependency. |
|
[HELIOS-CODEX] Versioning rule corrected.\n\nUse this pattern from now on: <project_version>-<codex_minor>.<codex_patch>.\n\n- project version: 0.1.3\n- codex version: 0.123.1\n- corrected composite version: 0.1.3-${codex_version#0.} |
HELIOS-CODEX versioning correctionUse the corrected composite rule:
Please keep prior HELIOS notes but normalize package/version fields to this format in labels, release notes, and future comments. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
b03bf01
into
feat/cliproxy-service-runtime-worktree
Layered CI fix PR for feat/cliproxy-service-runtime-worktree.
Summary by CodeRabbit