fix(ci): align required-check manifest with current workflow job names#515
Closed
KooshaPari wants to merge 11 commits intomainfrom
Closed
fix(ci): align required-check manifest with current workflow job names#515KooshaPari wants to merge 11 commits intomainfrom
KooshaPari wants to merge 11 commits intomainfrom
Conversation
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @KooshaPari, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on a comprehensive update of import paths throughout the codebase, indicating a change in the project's repository location. Beyond this structural change, it introduces several targeted enhancements to improve the stability, security, and functionality of various components. Key improvements include better handling of file paths for Claude tokens, more robust OIDC region validation, and a more efficient mechanism for fetching web search tool descriptions. Additionally, specific bugs related to Gemini API tool schema conversion and Claude request content handling have been resolved. Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily consists of a large-scale refactoring to update import paths across the codebase, which seems to be related to a repository rename or fork. The changes are mostly correct, but I've found a few issues. There's a critical issue with a missed import path update that will break the build. I also found a potential logic bug in the truncation detection logic and a minor issue with redundant logging. Please see my detailed comments.
| type SDKConfig struct { | ||
| // ProxyURL is the URL of an optional proxy server to use for outbound requests. | ||
| ProxyURL string `yaml:"proxy-url" json:"proxy-url"` | ||
| import sdkconfig "github.com/router-for-me/CLIProxyAPI/v6/sdk/config" |
There was a problem hiding this comment.
This import path has not been updated to the new repository path. This will cause a build failure.
Suggested change
| import sdkconfig "github.com/router-for-me/CLIProxyAPI/v6/sdk/config" | |
| import sdkconfig "github.com/kooshapari/cliproxyapi-plusplus/v6/sdk/config" |
Comment on lines
+56
to
69
| // RequiredFieldsByTool maps tool names to their required fields. | ||
| // If any of these fields are missing, the tool input is considered truncated. | ||
| var RequiredFieldsByTool = map[string][]string{ | ||
| "Write": {"file_path", "content"}, | ||
| "write_to_file": {"path", "content"}, | ||
| "fsWrite": {"path", "content"}, | ||
| "create_file": {"path", "content"}, | ||
| "edit_file": {"path"}, | ||
| "apply_diff": {"path", "diff"}, | ||
| "str_replace_editor": {"path", "old_str", "new_str"}, | ||
| "Bash": {"command", "cmd"}, // Ampcode uses "cmd", others use "command" | ||
| "execute": {"command"}, | ||
| "run_command": {"command"}, | ||
| } |
There was a problem hiding this comment.
The refactoring of RequiredFieldsByTool and findMissingRequiredFields has introduced a logic error. The previous implementation correctly handled alternative required fields (e.g., cmd OR command for the Bash tool) by using groups. The new implementation checks for the presence of ALL fields listed for a tool, which is incorrect for tools with alternative field names like Bash.
For example, for the Bash tool, it will now require both command and cmd to be present, which is incorrect based on the comment // Ampcode uses 'cmd', others use 'command'.
This logic should be reverted to its previous state to correctly handle alternative fields. You should also revert the findMissingRequiredFields function to its previous implementation.
// RequiredFieldsByTool maps tool names to their required field groups.
// Each outer element is a required group; each inner slice lists alternative field names (OR logic).
// A group is satisfied when ANY one of its alternatives exists in the parsed input.
// All groups must be satisfied for the tool input to be considered valid.
//
// Example:
// {{"cmd", "command"}} means the tool needs EITHER "cmd" OR "command".
// {{"file_path"}, {"content"}} means the tool needs BOTH "file_path" AND "content".
var RequiredFieldsByTool = map[string][][]string{
"Write": {{"file_path"}, {"content"}},
"write_to_file": {{"path"}, {"content"}},
"fsWrite": {{"path"}, {"content"}},
"create_file": {{"path"}, {"content"}},
"edit_file": {{"path"}},
"apply_diff": {{"path"}, {"diff"}},
"str_replace_editor": {{"path"}, {"old_str"}, {"new_str"}},
"Bash": {{"cmd", "command"}},
"execute": {{"command"}},
"run_command": {{"command"}},
}| @@ -61,13 +70,20 @@ func (ts *ClaudeTokenStorage) SaveTokenToFile(authFilePath string) error { | |||
| misc.LogSavingCredentials(authFilePath) | |||
There was a problem hiding this comment.
This log call is redundant and logs the original, potentially unsafe authFilePath. The subsequent call on line 78 logs the sanitized safePath. This first call should be removed to avoid logging unsanitized data and to remove redundancy.
Owner
Author
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Owner
Author
|
Closing: stale with merge conflicts. Reopen and rebase if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up PR to align required checks against pr-test-build.yml|build and path-guard job.