Skip to content

fix: align sdk codex auth imports with internal types#620

Closed
KooshaPari wants to merge 1 commit intomainfrom
fix/pr617-main-ci-fix1
Closed

fix: align sdk codex auth imports with internal types#620
KooshaPari wants to merge 1 commit intomainfrom
fix/pr617-main-ci-fix1

Conversation

@KooshaPari
Copy link
Copy Markdown
Owner

Summary

  • switch sdk codex login imports from pkg llmproxy auth stack to internal auth stack
  • align sdk/auth/codex.go with buildAuthRecord signature in sdk/auth/codex_device.go

Why

PR #617 fails CodeQL/go build because buildAuthRecord expects internal/auth/codex types while sdk/auth/codex.go constructed pkg/llmproxy/auth/codex types.

Validation

  • fixes compile-time type mismatch in CI for sdk/auth/codex.go

Co-authored-by: Codex <noreply@openai.com>
@gemini-code-assist
Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Feb 26, 2026

Warning

Rate limit exceeded

@KooshaPari has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 25 minutes and 36 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 6e7b545 and 30d3b9f.

📒 Files selected for processing (1)
  • sdk/auth/codex.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/pr617-main-ci-fix1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@KooshaPari
Copy link
Copy Markdown
Owner Author

Superseded by #621 and #622; closing this PR in favor of the merged replacements.

@KooshaPari KooshaPari closed this Feb 26, 2026
@KooshaPari KooshaPari reopened this Feb 27, 2026
@KooshaPari KooshaPari closed this Feb 27, 2026
@KooshaPari KooshaPari deleted the fix/pr617-main-ci-fix1 branch February 27, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant