hour_effect_v2: add configurable MQTT-driven 3D printer effect#23
Open
KrX3D wants to merge 6 commits intohour_effect_v2from
Open
hour_effect_v2: add configurable MQTT-driven 3D printer effect#23KrX3D wants to merge 6 commits intohour_effect_v2from
KrX3D wants to merge 6 commits intohour_effect_v2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/3dPrinterFinshed+truebehavior while allowing richer control from a new topic.Description
parse3DPrinterEffectPayload(...)to parse JSON payloads and extractr/g/b/w,effect/mode,speed,intensity,palette, anddurationMs/durationwith clamping and optionalactive/trigger/statehandling.3dPrinterEffectinonMqttConnectand extended message handling inonMqttMessageto accept either the legacy/3dPrinterFinshedor the new/3dPrinterEffecttopic.applyEffectSettings(...), and use a per-triggeractiveResetDelayMsvalue (bounded) for reset timing.Testing
rg) and file excerpts to ensure hooks were placed inonMqttConnect,onMqttMessage, and reset logic, and verified the newparse3DPrinterEffectPayloaddeclaration and implementation.git diff --statto confirm the intended modifications tousermods/hour_effect_v2/hour_effect_v2.cppand.h.git diff --checkwhich initially reported trailing-whitespace warnings that were addressed before committing, and then committed the changes successfully.Codex Task