Delete counters of qualified limits #399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsnaps
commented
Dec 11, 2024
| let l = limit.clone(); | ||
| match self | ||
| .qualified_counters | ||
| .invalidate_entries_if(move |c, _| c.limit() == &l) |
Member
Author
There was a problem hiding this comment.
Whether an entry actually needs invalidation will be checked for on the .get path by moka... so this isn't racy
alexsnaps
requested review from
kuadrant-dev
and removed request for
adam-cattermole
adam-cattermole
approved these changes
Jan 30, 2025
Member
adam-cattermole
left a comment
adam-cattermole
left a comment
There was a problem hiding this comment.
Sorry for the slow review, I looked at it before and meant to get back to it
Signed-off-by: Alex Snaps <alex@wcgw.dev>
Signed-off-by: Alex Snaps <alex@wcgw.dev>
Signed-off-by: Alex Snaps <alex@wcgw.dev>
alexsnaps
force-pushed
the
qualified_deletes
branch
from
113aef4 to
0acb833
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think this is really a desirable fix to be honest...
O(n)isn't really sustainable.Probably resorting to a ordered collection and have all qualified counters for a qualified limit next to each other would be better... I'll see what I can do as part of #397