Bump rocksdb to 0.24 #451
Open
Bump rocksdb to 0.24 #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eguzki Astiz Lezaun <eastizle@redhat.com>
eguzki
force-pushed
the
upgrade-rocksdb
branch
from
3ec130e to
f579922
Compare
Contributor
Author
|
There is a temporary issue for this PR. The required librocksdb-sys 0.17.3 version that has the fix to be compiled with c+`+ 15, requires rust 1.85.0. RHEL for the downstream only supports 1.84.1 as of today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Bump rocksdb to 0.24
Why
rocksdbdepends on librocksdb-sys` crate. Rocksdb 0.22 depends on librocksdb-sys 0.16.0.Recently I upgraded my Fedora's c++ compiler to 15. With c++ 15, librocksdb-sys 0.16.0 cannot be compiled, because
#include <cstdint>is missing. Some C++ Standard Library headers have been modified to no longer include other headers that were previously used internally. As a result, C++ programs that rely on standard library components without explicitly including the appropriate headers will now fail to compile.This has been fixed in librocksdb-sys 0.17.x and now compiles.