Skip to content

Remove old Logger #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hageshtrem merged 1 commit into from
Feb 1, 2024
Merged

Remove old Logger #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dead_pool_reaper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ func (r *deadPoolReaper) cleanStaleLockInfo(poolID string, jobTypes []string) er
return err
}
if len(negativeLocks) > 0 {
Logger.Printf("Reaper: negative locks: %v", negativeLocks)
r.logger.Info("Reaper: negative locks", slog.Any("keys", negativeLocks))
}

return nil
Expand Down
3 changes: 0 additions & 3 deletions worker_pool_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"bytes"
"context"
"fmt"
"log"
"reflect"
"testing"
"time"
Expand Down Expand Up @@ -227,8 +226,6 @@ func TestWorkerPoolTracing(t *testing.T) {
ctx, span := tp.Tracer("").Start(context.Background(), "enqueue")
span.End()

Logger = log.Default()

enqueuer := NewEnqueuer(ns, pool)

_, err := enqueuer.EnqueueContext(ctx, jobName, Q{"a": "b"})
Expand Down
3 changes: 0 additions & 3 deletions worker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package work
import (
"fmt"
"io"
"log"
"strconv"
"sync"
"sync/atomic"
Expand Down Expand Up @@ -636,8 +635,6 @@ func TestWorkerPoolStop(t *testing.T) {
}

func TestWorkerRetryRemoveFromInProgress(t *testing.T) {
Logger = log.Default()

originPool := newTestPool(":6379")
pool := newSwitchablePool(originPool)
ns := "work"
Expand Down